Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect use of getattr #16498

Merged
merged 3 commits into from
Dec 25, 2024
Merged

fix incorrect use of getattr #16498

merged 3 commits into from
Dec 25, 2024

Conversation

zzstoatzz
Copy link
Collaborator

closes #16486

#16445 introduced an incorrect use of getattr where block.__class__.__name__ should have instead been block, which explains the linked issue

@github-actions github-actions bot added the bug Something isn't working label Dec 25, 2024
Copy link

codspeed-hq bot commented Dec 25, 2024

CodSpeed Performance Report

Merging #16498 will not alter performance

Comparing fix-16486 (0c440cd) with main (c7282e8)

Summary

✅ 3 untouched benchmarks

@zzstoatzz zzstoatzz marked this pull request as ready for review December 25, 2024 04:31
@zzstoatzz zzstoatzz added the fix A fix for a bug in an existing feature label Dec 25, 2024
@cicdw cicdw merged commit b11b56f into main Dec 25, 2024
38 checks passed
@cicdw cicdw deleted the fix-16486 branch December 25, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix A fix for a bug in an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'str' object has no attribute 'awrite_path'
2 participants