Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing dependancies sorting issue "You first need to define an entry before using a relation with" #48

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixing dependancies sorting issue "You first need to define an entry before using a relation with" #48

wants to merge 2 commits into from

Conversation

lukaslau
Copy link

@lukaslau lukaslau commented May 19, 2023 •
edited by matks
Loading

Questions Answers
Description? Because of cariage return symbol dependancies sorting was working incorectly this is why you can get and error "You first need to define an entry before using a relation with %"
Type? bug fix
BC breaks? yes
Deprecations? no
Fixed ticket? Fixes #4 .
How to test? Please follow steps in #4
Sponsor company Elpresta

matks
matks previously approved these changes May 20, 2023
View reviewed changes
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lukaslau ! QA team is going to verify this PR impact 😉

@matks matks mentioned this pull request May 20, 2023
Open
@paulnoelcholot
Copy link

Hello @lukaslau,

Some checks were unsuccessful, so I will remove the Waiting for QA label until the problem is solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tleon tleon tleon approved these changes

@matks matks matks left review comments

Assignees
No one assigned
Labels
None yet
Projects
PR Dashboard
Status: Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error "You first need to define an entry before using a relation with supplier"
4 participants
@lukaslau @paulnoelcholot @matks @tleon