Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions / suggestions for "Add/Edit a Catalog Price Rule" - condition groups specs #115

Open
matks opened this issue May 4, 2020 · 0 comments
Assignees

Comments

@matks
Copy link
Contributor

matks commented May 4, 2020

Questions for https://github.com/PrestaShop/prestashop-specs/blob/master/back-office/catalog/catalog-price-rules.md

As I am going to migrate this, I checked how it behave. I saw some strange things.

  • If you create a 1st condition group, then a 2nd one, you cannot edit the 1st. Adding conditions and hitting the "Add condition" button will add conditions to the 2nd group, not the 1st. The 1st group can never be edited again. => not an issue, but worth noticing
  • If you create a 1st condition group, then a 2nd one, then you save and leave the page ; then you open again the page, hitting "Add condition" button will not do anything. You can now create a 3rd group of conditions but you cannot edit the 1st and 2nd groups. => I suggest some error message to explain this to user, else user thinks it's broken
  • When you click "delete" on a condition inside a condition group, if you dont hit the "Save" button on the page (which is above), it will not be really deleted. => would be nice to find a UX way to tell user 'OK we understood your need but until you have saved, it will not be taken into account'
  • If you hit "delete" on all conditions of a condition group, the group remains (empty) until you hit "save" => shall it be fixed by UX improvement ?
  • You cannot add twice the same condition in a group (it makes sense), but nothing explains it: no error message, hitting the button "Add condition" will just do nothing => shall it be fixed by UX improvement ?
  • It is not obvious that you need to hit "save" button to persist created condition groups, and the "save" button is small and above the form => shall it be fixed by UX improvement ? bigger button, multiple buttons ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants