Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration test for "category deletion and the impact on associated products" #24668

Closed
wants to merge 3 commits into from
Closed

Integration test for "category deletion and the impact on associated products" #24668

wants to merge 3 commits into from

Conversation

arouiadib
Copy link
Contributor

@arouiadib arouiadib commented May 26, 2021 •
edited
Loading

Questions Answers
Branch? develop
Description? Integration test for category deletion and impact on associated products.
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/prestashop-specs#228
How to test? run php ./vendor/bin/behat -c tests/Integration/Behaviour/behat.yml --name="Delete category"
Possible impacts? None

This change is Reviewable

@arouiadib arouiadib requested a review from a team as a code owner May 26, 2021 16:01
@prestonBot prestonBot added develop Branch Bug fix Type: Bug fix labels May 26, 2021
@arouiadib arouiadib force-pushed the behat-tests-9811 branch 2 times, most recently from 57d6a54 to 83ed2b1 Compare May 26, 2021 16:06
@arouiadib arouiadib changed the title Integration tests for category deletion with associated products reassigned Integration test for category deletion and impact on associated products May 26, 2021
@prestonBot prestonBot added the Refactoring Type: Refactoring label May 26, 2021
@arouiadib arouiadib changed the title Integration test for category deletion and impact on associated products Integration test for "category deletion and the impact on associated products" May 26, 2021
@arouiadib arouiadib changed the title Integration test for "category deletion and the impact on associated products" [WIP] Integration test for "category deletion and the impact on associated products" Jun 9, 2021
@arouiadib arouiadib mentioned this pull request Jun 11, 2021
Open
@arouiadib
Copy link
Contributor Author

@kpodemski @PululuK Thanks a lot for your first feedback.
The PR now contains only tests and I would love to receive your CR.

The changes you already suggested will be taken into account in another PR (that contains the fix).

@arouiadib arouiadib mentioned this pull request Aug 4, 2021
Closed
@arouiadib arouiadib changed the title [WIP] Integration test for "category deletion and the impact on associated products" Integration test for "category deletion and the impact on associated products" Aug 4, 2021
@PierreRambaud
Copy link
Contributor

Hi @arouiadib are you still working on it because CI is failing?

@PierreRambaud PierreRambaud added Waiting for QA Status: action required, waiting for test feedback Waiting for author Status: action required, waiting for author feedback and removed Waiting for QA Status: action required, waiting for test feedback labels Nov 15, 2021
@arouiadib arouiadib closed this Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PululuK PululuK PululuK left review comments

@kpodemski kpodemski kpodemski requested changes

Assignees
No one assigned
Labels
Bug fix Type: Bug fix develop Branch Refactoring Type: Refactoring Waiting for author Status: action required, waiting for author feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete main category of product, product should be reassigned another main category
5 participants
@arouiadib @PierreRambaud @kpodemski @PululuK @prestonBot