-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to nex-go v2 #4
Open
ItzSwirlz
wants to merge
6
commits into
PretendoNetwork:master
Choose a base branch
from
ItzSwirlz:nex-v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+378
−444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItzSwirlz
changed the title
[WIP] chore: update to nex-go v2
chore: update to nex-go v2
Jul 18, 2024
ItzSwirlz
commented
Jul 23, 2024
} | ||
|
||
// The user must be kicked, otherwise the app hangs forever. | ||
globals.NEXServer.TimeoutKick(client) | ||
// globals.NEXServer.TimeoutKick(client) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only area of concern about this PR. How to handle the timeout kick.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3
Changes:
Update to nex-go v2.0
Now uses the nex-protocols-common-go implementations of the Match Making, Match Making Ext and Match Make Extension protocol (along with the servers own handler methods)
Requires the new environment variable
PN_WIIU_CHAT_KERBEROS_PASSWORD
Uses GRPC for account authentication. This comes with its respective environment variables
I have read and agreed to the Code of Conduct.
I have read and complied with the contributing guidelines.
What I'm implementing was an approved issue.
I have tested all of my changes.
Testing this locally will require some rigging to wiiu-chat-authentication (switching it to the ticket-granting protocol) for it to work. I don't have more than one Wii U, but I was able to get into the main Wii U Chat menu.