Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardness value of 0 for some stairs/slabs in 1.16.2 #335

Closed
TheMode opened this issue Oct 2, 2020 · 6 comments
Closed

Hardness value of 0 for some stairs/slabs in 1.16.2 #335

TheMode opened this issue Oct 2, 2020 · 6 comments

Comments

@TheMode
Copy link

TheMode commented Oct 2, 2020

I have a project dependent on those data, didn't check other versions.

Some examples:
https://github.com/PrismarineJS/minecraft-data/blob/master/data/pc/1.16.2/blocks.json#L3936
https://github.com/PrismarineJS/minecraft-data/blob/master/data/pc/1.16.2/blocks.json#L20169

Stairs seem to be much more affected than slabs
(Specifying that I am using 1.16.3, but data is shared with 1.16.2)

@TheMode
Copy link
Author

TheMode commented Oct 5, 2020

https://minecraft-data.prismarine.js.org/?d=blocks
If you rank blocks by hardness value in increasing order, you can see that it affects:

  • Stairs
  • Slabs
  • Walls
  • Bricks

And probably some other exceptions

@rom1504
Copy link
Member

rom1504 commented Oct 5, 2020

ok we probably need to find a good way to extract those from the jar

@TheDudeFromCI
Copy link
Member

This seems to affect all 1.16.x versions.
1.15.x and below are working correctly.

@TheMode
Copy link
Author

TheMode commented Nov 3, 2020

Similarly to all of this, the "boundingBox" field is flawed
https://github.com/PrismarineJS/minecraft-data/blob/master/data/pc/1.16.2/blocks.json#L12024
Carpets are all considered as having a bounding box, same for rails and probably other exceptions

(I didn't want to fill another issue since it is probably for the same reason)

@rom1504
Copy link
Member

rom1504 commented Nov 3, 2020

feel free to either PR the fix, either PR the extractor to regenerate the data properly

@nickelpro
Copy link
Member

Fixed in #384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants