-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Vite? #253
Comments
try it, if it works faster without breaking things then let's do it yet |
I tried it in https://github.com/PrismarineJS/prismarine-viewer/tree/master/examples/standalone. Kinda fast, but doesn't work at all. Polyfilling node with it is much harder than I expected (they're doing it on purpose as its not recommended). And also about this repo, Vite would punish you for 500kb bundle size, but here, index.js have ~35mb. Have you thought about getting rid of polyfilling node in favor of more clean solution? Anyway, I'll keep exploring ways to make it work : |
What would be a more clean solution? |
re-open if you feel like investigating this more deeply |
I really wanted to see it here, but unfortunately didn't have much time recently :( I'll try to take a fresh look into it in next year.
Get rid of polyfylling node modules. Btw, with Snowpack it was extremely easy. It supported Hope I made it clear, feel free correct me. |
ok let's re-open to discuss |
yes I'm asking about your solution to do that and that would be cleaner than polyfilling |
supporting node modules is the main reason why we use webpack to begin with, so that doesn't seem to work here |
something interesting is that webpack is going straight in the wrong direction by removing all the polyfilling by default |
I will note that dev build performance has magically increased a lot recently for me though |
Hi all! How's it going? I've finally managed to put my focus on this fantastic project (I've promised sandboxed mc to a lot of folks). Btw what about Vite, it turns out it wasn't that hard to polyfill node modules (though it still doesn't support false aliases). eg prismarine-viewer works fine with Vite setup, however, the performance is still far from ideal... I will continue investigating it. What I really miss from the current setup is the hot reload. eg if I make any changes I need to fully reload the page, reconnect, and so on... Are there other changes you might be interested in? i see some code parts are hid/in corect |
It Might resolve #210 in a better way.
Its kinda popular alternative, have you ever tried it? For me in projects at any scale it always served an extreme performance. For now I’m just asking here, will try it here in a few days.
The text was updated successfully, but these errors were encountered: