Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues in #marketing.html file. #613

Closed
anshumangahlot opened this issue Oct 18, 2024 · 3 comments
Closed

Issues in #marketing.html file. #613

anshumangahlot opened this issue Oct 18, 2024 · 3 comments

Comments

@anshumangahlot
Copy link
Contributor

anshumangahlot commented Oct 18, 2024

Issues:

  1. Incorrect Meta Description:

The meta description incorrectly mentions "Modern Physics skills" instead of "digital marketing skills."

  1. Typo in Image Filename:

The image filename for the "Introduction to Digital Marketing" card is digtal.jpg, which is a typo.

  1. Image Aspect Ratio:

Images are currently set to a width of 300 and height of 100, which may lead to distortion.

  1. Accessibility of Links:

Anchor tags do not have visible text, which may hinder accessibility.

  1. Lack of Semantic HTML:

The HTML structure lacks semantic tags such as header, main, and footer tag.

  1. Insufficient alt Text Descriptions:

Some alt text descriptions for images are too brief (e.g., "SEO image").

  1. Responsive Design:

Although the viewport meta tag is included, the CSS needs to ensure responsiveness on different devices.

  1. Duplicate Titles in Course Cards:

Course titles are quite similar, which may affect SEO.

Additionally Note:
I am submitting a Pull request(#689) which fixes the issues listed above.

Copy link

Thank you for creating this issue! 🎉 Your issue will soon be reviewed by Project Maintainers. In the meantime, please make sure to provide all the necessary details and context. If you have any questions or additional information, feel free to add them here. Your contributions are highly appreciated! 😊

You can also check our CONTRIBUTING.md for guidelines on contributing to this project.

Copy link

Thanks for creating the issue in SkillWise!
Before you start working on your PR, please make sure to:

  • ⭐ Star the repository if you haven't already.
  • Pull the latest changes to avoid any merge conflicts.
  • Attach before & after screenshots in your PR for clarity.
  • Include the issue number in your PR description for better tracking.
    Don't forget to follow @PriyaGhosal – Project Maintainer – & @anuragverma108 – Project Collaborator – for more updates!

We're excited to see your contribution as part of Hacktoberfest 2024! 🎉
Happy open-source contributing!

@nevil2006
Copy link

Incorrect Meta Description:

Action: Update the meta description to reflect "digital marketing skills" accurately. Ensure it succinctly summarizes the content of the page while incorporating relevant keywords.
Typo in Image Filename:

Action: Rename the image file from digtal.jpg to digital.jpg to correct the typo and improve file organization.
Image Aspect Ratio:

Action: Adjust the CSS for images to maintain their aspect ratio. You can use properties like object-fit: cover; or max-width: 100%; height: auto; to prevent distortion.
Accessibility of Links:

Action: Ensure all anchor tags contain meaningful text. If the links must be visually hidden, consider using aria-label attributes to maintain accessibility.
Lack of Semantic HTML:

Action: Revise the HTML structure to include semantic tags. For example:
html
Copy code

... ... ... This helps search engines and screen readers better understand the structure of your content.

Insufficient Alt Text Descriptions:

Action: Improve the alt text for images by providing more descriptive text. Instead of just "SEO image," use something like "Illustration of SEO strategies in digital marketing."
Responsive Design:

Action: Review your CSS to ensure it uses relative units (like percentages or em/rem) instead of fixed pixel values. Additionally, use media queries to adapt styles for different screen sizes.
Duplicate Titles in Course Cards:

Action: Differentiate course titles by making them more descriptive or unique. Consider including the specific focus of each course to enhance SEO and clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants