Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product question: when to hide label editing #5

Open
JeroenDeDauw opened this issue Mar 24, 2022 · 3 comments
Open

Product question: when to hide label editing #5

JeroenDeDauw opened this issue Mar 24, 2022 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@JeroenDeDauw
Copy link
Member

Premise: It does not make sense to show label editing UI in cases where labels are automatically generated. After all, when someone uses the editing UI, their edit will just be overridden by generated value.

	"buildLabel": {
		"en": {
			"P2": "$"
		},
		"de": {
			"P2": "$"
		}
	},

Question: in case of the above rule applying to the entity, which labels do we prevent editing for? Just the English and German ones? Or all labels?

Further question: does it typically even make sense for people to be able to add labels in other languages in the types of wikis where rules are used to generate labels? Perhaps it is typically better to restrict label editing to the language or languages the dataset is officially maintained in.

@mzeinstra
Copy link
Collaborator

Question: in case of the above rule applying to the entity, which labels do we prevent editing for? Just the English and German ones? Or all labels?

All labels see also #4

Further question: does it typically even make sense for people to be able to add labels in other languages in the types of wikis where rules are used to generate labels? Perhaps it is typically better to restrict label editing to the language or languages the dataset is officially maintained in.

Can we restrict label editing in a certain language with Wikibase? I thought the user rolls only allow editing enabled or disabled.

@JeroenDeDauw
Copy link
Member Author

Can we restrict label editing in a certain language with Wikibase? I thought the user rolls only allow editing enabled or disabled.

There are no permissions or other config that allow restricting which languages a label can be set in. In AutomatedValues we thus need to create our own approach. This approach would just be surface-level hiding of the editing UI. You would still be able to set labels via the web API. More fine grained language based restrictions sounds like an idea for another extension :)

@digitaalwerktuig
Copy link
Collaborator

digitaalwerktuig commented Mar 24, 2022

That approach (surface-level hiding of the editing UI) works for our use case, I would say.

Additional note: "our use case" refers to the LUDAP project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants