Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ranges with open start/end date #12

Open
JeroenDeDauw opened this issue Jan 27, 2021 · 7 comments
Open

Add support for ranges with open start/end date #12

JeroenDeDauw opened this issue Jan 27, 2021 · 7 comments
Labels
potential-enhancement Not ready for implemenation - needs discussion first

Comments

@JeroenDeDauw
Copy link
Member

JeroenDeDauw commented Jan 27, 2021

While we support ranges with open start or end like ../~2004-06-20, we do not support start or end that has a date and is open at the same time, like ..2004-06-01/~2004-06-20. While the later is not part of the public EDTF spec, it appears as example in a proprietary spec.

@JeroenDeDauw JeroenDeDauw added the bug Something isn't working label Jan 27, 2021
@JeroenDeDauw
Copy link
Member Author

From @mzeinstra:

Level 2: Date: Combining advanced Qualification with range element expansion and time intervals.

Example: '..2004-06-01/~2004-06-20 (beginning before or on 1 June 2004 and ending approximately the 20th)

@JeroenDeDauw
Copy link
Member Author

@mzeinstra are we sure that is a valid EDTF value? I'm not seeing any combination of .. (open interval) and dates in https://www.loc.gov/standards/datetime/. It also looks like other implementations do not support this.

@mzeinstra
Copy link
Collaborator

I've put it on the mail to Claude and Lucien to answer this questions.

I've not seen the formal EDTF standard that they have been using: https://www.iso.org/standard/70908.html

@JeroenDeDauw JeroenDeDauw self-assigned this Feb 9, 2021
@JeroenDeDauw
Copy link
Member Author

Now confirmed: this is valid EDTF, even though it is not listed in https://www.loc.gov/standards/datetime/

Our current object model cannot express those dates, so adding support is non-trivial (though also not that much work).

@JeroenDeDauw JeroenDeDauw removed their assignment Feb 13, 2021
@JeroenDeDauw
Copy link
Member Author

More examples in e328f53

@mzeinstra
Copy link
Collaborator

I am not quite sure I understand why these dates fail in the date representation.

I see that dates with .. seem to proces in the Valid Strings Ln92,96,100 do validate right?

		yield '[..1760-12-03]';
		yield '[..1984]';
		yield '{..1984}';

so why would the following not work?

//		yield '..1984';
//		yield '1984..';
//		yield '1670..1673';

@JeroenDeDauw JeroenDeDauw changed the title Fix handing of ..2004-06-01/~2004-06-20 Add support for ranges with open start/end Mar 12, 2021
@JeroenDeDauw JeroenDeDauw changed the title Add support for ranges with open start/end Add support for ranges with open start/end date Mar 12, 2021
@JeroenDeDauw JeroenDeDauw added enhancement New feature or request and removed bug Something isn't working labels Mar 12, 2021
@JeroenDeDauw
Copy link
Member Author

Replied with #46

@JeroenDeDauw JeroenDeDauw added potential-enhancement Not ready for implemenation - needs discussion first and removed enhancement New feature or request labels Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential-enhancement Not ready for implemenation - needs discussion first
Projects
None yet
Development

No branches or pull requests

2 participants