Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all code is tested #57

Open
JeroenDeDauw opened this issue Mar 19, 2021 · 2 comments
Open

Ensure all code is tested #57

JeroenDeDauw opened this issue Mar 19, 2021 · 2 comments
Assignees
@JeroenDeDauw
Labels
enhancement New feature or request

Comments

@JeroenDeDauw
Copy link
Member

Get https://app.codecov.io/gh/ProfessionalWiki/EDTF to 100%

Add missing @covers and missing tests.

Most missing coverage on codecov is likely due to due missing @covers tags. Keep in mind we want all logic to be tested. This requirement is more strict than line code coverage.
@JeroenDeDauw JeroenDeDauw added the enhancement New feature or request label Mar 19, 2021
@mzeinstra
Copy link
Collaborator

Friendly warning that since you've exposed en.json to Translatewiki some of your test could fail due to changes in the community. Right @JeroenDeDauw

@JeroenDeDauw
Copy link
Member Author

Indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeroenDeDauw JeroenDeDauw

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JeroenDeDauw @mzeinstra @chaudbak