Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should EDTF dates with only a year be humanised to year <year> #93

Open
mzeinstra opened this issue Jan 30, 2023 · 5 comments
Open

Should EDTF dates with only a year be humanised to year <year> #93

mzeinstra opened this issue Jan 30, 2023 · 5 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@mzeinstra
Copy link
Collaborator

Some community members argued that dates like '2023', '1800', '1924' should be humanised to 'year 2023', 'year 1800', 'year 1924', etc.

I would like to have an open community discussion on this. Are people in favor/against this? Until we have some input we will have this labeled as a question.

@mzeinstra mzeinstra added help wanted Extra attention is needed question Further information is requested labels Jan 30, 2023
@JeroenDeDauw
Copy link
Member

We actually already have humanizations of years. See 100 in
image

We purposefully did not humanize years such as 1984 since people already understand what you mean. The differentiation is really simple at the moment, and perhaps should also include an upper bound such as 3000.

image

Or perhaps we should drop the check and always show a humanization. All those options are trivial to implement.

@JeroenDeDauw
Copy link
Member

Here is a better version of the "smart" behavior: #94

@cnralux
Copy link
Collaborator

cnralux commented Jan 31, 2023

I find it quite strange that almost all EDTF strings get a humanized string (= the gray text in brackets), except for positive "year only"-dates, where that space remains empty.

#94 might be a solution, but what about years like 1234 or 2222? Do users recognize them as years or as typos? Adding "year" could harmonize this for all forms of EDTF strings with "year only"-dates (including those starting with "Y").

@JeroenDeDauw
Copy link
Member

JeroenDeDauw commented Jan 31, 2023

This is actually not trivial to fix. Here are examples of changed humanization if we always humanize year. We should at least pay attention to context so that "year" does not get inserted inside of other messages where it really is not needed.

.- 'February 14th, 2021'
+'February 14th, Year 2021'

-'2019 to 2021'
+'Year 2019 to Year 2021'

-'01:02:03 UTC April 12th, 1985'
+'01:02:03 UTC April 12th, Year 1985'

-'January 1st, 1000, April 20th, 4242 or a day in between'
+'January 1st, Year 1000, April 20th, Year 4242 or a day in between'

@JeroenDeDauw
Copy link
Member

Decision together with @mzeinstra and @digitaalwerktuig: we will not always humanize years because of the above issue with compound messages.

Potential improvement to smart behavior: #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants