-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
template parameter does not work correctly #19
Comments
Thanks for reporting this issue! |
I had also seen similar behavior but had not had time to investigate the cause. |
Hi |
Unfortunately I cannot justify spending time on this without funding |
Hi Jeroen - I have a great interest in fixing the template rendering option of the Semantic MediaWiki SubPages extension. Do you have a rough idea of what amount of funding you might need to implement this properly? |
@pwinkeler my current day rate is several 1000 EUR, which I suspect is on the high side for an open-source fix :) If you wish you can write me with your budget at [email protected] and I'll see if it is sufficient to put one of our devs on it. |
That is a bit too much for me to bite off, you’re right. Fortunately I was able to somewhat work around this by setting a property on all the subpages of interest that I can then use to uniquely identify them with a regualr #ask query.
I do wish I had the time to understand the subpages code better so I could fix it myself but that will have to wait.
Thanks for the response though,
PaulW
… On Aug 9, 2021, at 13:01, Jeroen De Dauw ***@***.***> wrote:
@pwinkeler <https://github.com/pwinkeler> my current day rate is several 1000 EUR, which I suspect is on the high side for an open-source fix :) If you wish you can write me with your budget at ***@***.*** ***@***.***> and I'll see if it is sufficient to put one of our devs on it.
|
Using MW 1.25.1, I cannot seem to get the template parameter to work. Here are some examples using "Test Page", "Test Page/Subpage {1|2|3}", and "Template:Subpage list template" with the definition: "There is a subpage named {{{1}}}".
Works
Using parser function with defaults:
{{#subpages:}}
Using parser function with
pathstyle=full
:{{#subpages:pathstyle=full}}
Manually invoking template in a hand-built list:
* {{Subpage list template|Test Page/Subpage 1}}
* {{Subpage list template|Test Page/Subpage 2}}
* {{Subpage list template|Test Page/Subpage 3}}
Fails
Using parser function with the
template
parameter:{{#subpages:template=Subpage list template}}
It appears that the list is generated correctly, but the resulting output is not passed through the template renderer. This is apparently in part because FunctionRunner has no access to the Parser instance so cannot render the resulting text. Not sure.
Using tag mode with
template
parameter:<subpages template="My template"/>
HookRunner
callsParser->recursiveTagParse()
, but the expansion is messed up. The content doesn't get put into the list item, but outside, and each item becomes a separate list. It appears that each list item is resolved into complete HTML as a separate list rather than waiting until all the items are combined to render into a list.The text was updated successfully, but these errors were encountered: