Skip to content
This repository has been archived by the owner on Apr 10, 2023. It is now read-only.

Create add book modal #883

Closed
knjk04 opened this issue Jan 28, 2022 · 16 comments
Closed

Create add book modal #883

knjk04 opened this issue Jan 28, 2022 · 16 comments
Labels
enhancement New feature or improvement of an existing feature request frontend HTML, CSS or TypeScript related good first issue Good for newcomers react Implementation is in React (JSX with TypeScript) wontfix This will not be worked on

Comments

@knjk04
Copy link
Member

knjk04 commented Jan 28, 2022

Describe the solution you'd like

image

When a user clicks on the add book button on the 'my books' page, we should show the modal above.

  • Pressing cancel or the 'X' button should close the modal

  • Clicking reset should reset all fields to their default state

  • For now, we will assume there is only allowed to be one author

  • The pages field should only take integers (1 or greater)

  • For the status field, exactly one option should be chosen (not multiple). See below for what it should look like when an option is chosen

  • We should add validation to ensure that the book title and author's name field are not empty when the user clicks on the 'Add book' button

  • We should get the list of shelves from the /api/books/genres (GET) endpoint. A user can select only one genre from this list

image

  • We should get the list of shelves from the /api/shelf (GET) endpoint. A user can select multiple shelves from this list

image

  • When the user clicks on the add book button, we should call the /api/book (POST) endpoint

Additional context

  • Be sure to read the contributing guidelines first!
  • Discuss your implementation approach with us before we assign you to it
  • Provide us with an estimate on how long you think it will take you to complete
  • Branch from main and set main as the destination branch in your pull request

If you need help with anything, we'll be happy to help you over a GitHub Q&A discussion or our Slack workspace

@knjk04 knjk04 added enhancement New feature or improvement of an existing feature request good first issue Good for newcomers react Implementation is in React (JSX with TypeScript) frontend HTML, CSS or TypeScript related labels Jan 28, 2022
@samspecial
Copy link

Glad the design for the add-book feature is finally out and I am interested in bringing this to reality @knjk04

1 similar comment
@samspecial
Copy link

Glad the design for the add-book feature is finally out and I am interested in bringing this to reality @knjk04

@knjk04
Copy link
Member Author

knjk04 commented Jan 30, 2022

Thanks, @samspecial. How long do you think this will take you?

@samspecial
Copy link

Thanks, @samspecial. How long do you think this will take you?

2 days

@samspecial
Copy link

samspecial commented Feb 1, 2022

Thanks, @samspecial. How long do you think this will take you?

2 days

I am currently in the middle of a task which might hinder me from working on this immediately.
Kindly let me know if this seats well with you

@knjk04
Copy link
Member Author

knjk04 commented Feb 2, 2022

@samspecial That's fine, do you know roughly when you would be able to start working on this?

@samspecial
Copy link

@samspecial That's fine, do you know roughly when you would be able to start working on this?

I should commence in the new week - 7th February 2022 to be precise

@knjk04
Copy link
Member Author

knjk04 commented Feb 5, 2022

That's fine, thanks for the update!

@knjk04
Copy link
Member Author

knjk04 commented Feb 14, 2022

Hi @samspecial, how are you getting on with this?

@samspecial
Copy link

Hi @samspecial, how are you getting on with this?

@knjk04 I'll be starting today. Apologies for not updating you before now.

I will give an update later in the day

@knjk04
Copy link
Member Author

knjk04 commented Feb 18, 2022

@samspecial How are you getting on with this?

@samspecial
Copy link

@samspecial How are you getting on with this?

I have been ill lately, just got back to work. This is why I have not responded since Friday.

Currently clearing my table, I will share screenshot by tomorrow as I might not be able to work on it today.

Sincere apologies.

@knjk04
Copy link
Member Author

knjk04 commented Feb 21, 2022

@samspecial No problem at all, I'm glad to hear you're better now (or I hope you get better soon)!

@samspecial
Copy link

samspecial commented Feb 25, 2022

Hi @knjk04 I am currently having issues writing my code to adapt to what is obtainable in the project repo. I have not worked with TypeScript before this time. I would love to request you avail me this weekend to go through the rudiment and basic of TypeScript needed to come up with the implementation as I have gone to buy Maximilian Schwarzmüller which I trust will facilitate me learning

@knjk04
Copy link
Member Author

knjk04 commented Feb 27, 2022

Hi @samspecial, would it be OK if I assign you to #884 instead? It would be good if we can get this particular issue implemented soon because it would allow us to test and release quicker

@knjk04 knjk04 pinned this issue Mar 20, 2022
@stale
Copy link

stale bot commented May 6, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix This will not be worked on label May 6, 2022
@stale stale bot closed this as completed May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or improvement of an existing feature request frontend HTML, CSS or TypeScript related good first issue Good for newcomers react Implementation is in React (JSX with TypeScript) wontfix This will not be worked on
Projects
Status: Done
Development

No branches or pull requests

2 participants