diff --git a/.github/workflows/checkstyle.yml b/.github/workflows/checkstyle.yml new file mode 100644 index 00000000..91ea81d5 --- /dev/null +++ b/.github/workflows/checkstyle.yml @@ -0,0 +1,19 @@ +name: checkstyle + +on: pull_request + +jobs: + checkstyle_job: + runs-on: ubuntu-latest + name: Checkstyle job + steps: + - name: Checkout + uses: actions/checkout@v2 + - name: Run check style + uses: nikitasavinov/checkstyle-action@master + with: + github_token: ${{ secrets.GITHUB_TOKEN }} + reporter: 'github-pr-check' + level: error + fail_on_error: true + workdir: src \ No newline at end of file diff --git a/src/main/java/com/karankumar/booksapi/datafetchers/BookDataFetcher.java b/src/main/java/com/karankumar/booksapi/datafetchers/BookDataFetcher.java index 00b0cfcf..c704a38e 100644 --- a/src/main/java/com/karankumar/booksapi/datafetchers/BookDataFetcher.java +++ b/src/main/java/com/karankumar/booksapi/datafetchers/BookDataFetcher.java @@ -27,44 +27,46 @@ @DgsComponent public class BookDataFetcher { - private final BookService bookService; - public BookDataFetcher(BookService bookService) { - this.bookService = bookService; - } + private final BookService bookService; - @DgsData(parentType = DgsConstants.QUERY_TYPE, field = DgsConstants.QUERY.FindAllBooks) - public List findAllBooks() { - return bookService.findAll(); - } + public BookDataFetcher(BookService bookService) { + this.bookService = bookService; + } - @DgsData(parentType = DgsConstants.QUERY_TYPE, field = DgsConstants.QUERY.FindBookByIsbn13) - public Book findBookByIsbn13(@InputArgument(DgsConstants.BOOK.Isbn13) String isbn13) { - return bookService.findBookByIsbn13(isbn13); - } + @DgsData(parentType = DgsConstants.QUERY_TYPE, field = DgsConstants.QUERY.FindAllBooks) + public List findAllBooks() { + return bookService.findAll(); + } - @DgsData(parentType = DgsConstants.QUERY_TYPE, field = DgsConstants.QUERY.FindByAuthor) - public List findByAuthor(@InputArgument(DgsConstants.AUTHOR.FullName) String fullName) { - return bookService.findByAuthor(fullName); - } + @DgsData(parentType = DgsConstants.QUERY_TYPE, field = DgsConstants.QUERY.FindBookByIsbn13) + public Book findBookByIsbn13(@InputArgument(DgsConstants.BOOK.Isbn13) String isbn13) { + return bookService.findBookByIsbn13(isbn13); + } - @DgsData(parentType = DgsConstants.QUERY_TYPE, field = DgsConstants.QUERY.FindByPublisher) - public List findByPublisher(@InputArgument(DgsConstants.PUBLISHER.Name) String publisherName) { - return bookService.findByPublisher(publisherName); - } + @DgsData(parentType = DgsConstants.QUERY_TYPE, field = DgsConstants.QUERY.FindByAuthor) + public List findByAuthor(@InputArgument(DgsConstants.AUTHOR.FullName) String fullName) { + return bookService.findByAuthor(fullName); + } - @DgsData(parentType = DgsConstants.QUERY_TYPE, field = DgsConstants.QUERY.FindByTitleIgnoreCase) - public List findByTitle(@InputArgument(DgsConstants.BOOK.Title) String title) { - return bookService.findByTitle(title); - } + @DgsData(parentType = DgsConstants.QUERY_TYPE, field = DgsConstants.QUERY.FindByPublisher) + public List findByPublisher( + @InputArgument(DgsConstants.PUBLISHER.Name) String publisherName) { + return bookService.findByPublisher(publisherName); + } - @DgsData(parentType = DgsConstants.QUERY_TYPE, field = DgsConstants.QUERY.FindByGenre) - public List findByGenre(@InputArgument(DgsConstants.GENRE.Name) GenreName genreName) { - return bookService.findByGenre(genreName); - } + @DgsData(parentType = DgsConstants.QUERY_TYPE, field = DgsConstants.QUERY.FindByTitleIgnoreCase) + public List findByTitle(@InputArgument(DgsConstants.BOOK.Title) String title) { + return bookService.findByTitle(title); + } - @DgsData(parentType = DgsConstants.QUERY_TYPE, field = DgsConstants.QUERY.FindByAwardName) - public List findByAward(@InputArgument(DgsConstants.AWARD.AwardName) String awardName) { - return bookService.findByAward(awardName); - } + @DgsData(parentType = DgsConstants.QUERY_TYPE, field = DgsConstants.QUERY.FindByGenre) + public List findByGenre(@InputArgument(DgsConstants.GENRE.Name) GenreName genreName) { + return bookService.findByGenre(genreName); + } + + @DgsData(parentType = DgsConstants.QUERY_TYPE, field = DgsConstants.QUERY.FindByAwardName) + public List findByAward(@InputArgument(DgsConstants.AWARD.AwardName) String awardName) { + return bookService.findByAward(awardName); + } }