Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused projection layer in AttentionBlock #503

Open
ChristianHinge opened this issue Aug 30, 2024 · 1 comment
Open

Unused projection layer in AttentionBlock #503

ChristianHinge opened this issue Aug 30, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@ChristianHinge
Copy link

After wrapping a MONAI AutoencoderKL model in pytorch lightning, I got an error regarding an unused parameter in the custom AttentionBlock implementation.

diffusion_model_unet.py and autoencoderkl.py line 233:

self.proj_attn = nn.Linear(num_channels, num_channels)

To me, it looks like this layers is completely unused. I cannot tell whether it is a mistake that this parameter is unsued, or if it should have never been defined in the first place.

@virginiafdez
Copy link
Contributor

Hello,

Apologies for the delay.
This repository is going to be archived, as it has all been integrated into MONAI Core (https://github.com/Project-MONAI/MONAI).
I believe this issue has been addressed during the porting.
Could you check by using the latest MONAI version incorporating the generative functions? If the issue persists there, please do open an Issue in MONAI Core and we will have a look as soon as possible.

Thank you very much!

Virginia

@virginiafdez virginiafdez added the bug Something isn't working label Oct 25, 2024
@virginiafdez virginiafdez self-assigned this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants