-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HEDJitter Transform #5809
Comments
Welcome to your contribution. Hi @drbeh , Could you please help also take a look at this feature request? Thanks in advance. |
Hi @Ycblue, cc @JHancox |
Hi @drbeh, indeed they don't mention any direct head-to-head comparison. However, they did compare HED to HSV augmentation, which includes shifting hue and saturation values (ColorJitter also perturbs Brightness and Contrast.) In the paper HED-light and HSV-strong produce similar results, with HED-light scoring a bit better in most cases. As far as I know, there is also no ColorJitter function implemented for MONAI and I am actually unsure about the compatibility of MONAIs Transform class with torchvision transforms. Maybe there is interest in both? |
@Ycblue, thank you very much for your answers.
|
@drbeh thanks for the info on the wrapper transforms and the existing deconvolution implementations!
Where do you propose I start with the implementation? Should I use |
@Ycblue, sure you can use For implementation,
|
Thanks for the guidelines! I will check out the contribution guide.
|
Great!
|
Hi @Ycblue, absolutely! However, we try to keep the test data to a minimum necessary and avoid duplicates so could you please let us know what the test data that you want to include is and how it is obtained (to check the licensing)? |
I really just want to add this sample image, similar to the original Repo. |
Hi @Ycblue, thanks for your effort on HEDJitter. I was wondering where are you with your implementing unit tests? We can add a sample image but we should make sure that the image does not have any copyright (the license is compatible with Apache 2.0 license of MONAI). What I suggest to do is to implement the unittests using that sample image and test them locally (don't worry about the unittest failure in the CI/CD tests for now). We can validate it locally and use an image with compatible license for the CI/CD to pass. What do you think? |
For digital pathology applications, color augmentation in hematoxylin & eosin space has been shown to be a useful tool (https://arxiv.org/abs/1902.06543).
Essentially, the transform disentangles an RGB image into hematoxylin and eosin channels, perturbes the channels independently and then transforms the image back into RGB space.
A Pytorch version was already implemented (https://github.com/gatsby2016/Augmentation-PyTorch-Transforms) and I'm wondering if it could be integrated into MONAI.
If there is no ongoing project on this front, I can help implement this feature.
I don't have any experience contributing to MONAI yet, so I would need some assistance if that were the case.
Cheers.
The text was updated successfully, but these errors were encountered: