Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GDSDataset #6787

Merged
merged 7 commits into from
Jul 27, 2023
Merged

Update GDSDataset #6787

merged 7 commits into from
Jul 27, 2023

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Jul 27, 2023

Fixes #6786 .

Description

  • Update rst
  • Update the type of dtype to str

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
@KumoLiu KumoLiu requested review from wyli, ericspod and Nic-Ma July 27, 2023 09:24
@wyli
Copy link
Contributor

wyli commented Jul 27, 2023

/build

@wyli wyli enabled auto-merge (squash) July 27, 2023 10:10
@wyli wyli merged commit d89b457 into Project-MONAI:dev Jul 27, 2023
29 of 32 checks passed
KumoLiu added a commit to KumoLiu/MONAI that referenced this pull request Jul 28, 2023
Fixes Project-MONAI#6786 .

### Description

- Update rst
- Update the type of dtype to str

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: KumoLiu <[email protected]>
@KumoLiu KumoLiu deleted the update-gdsdataset branch July 31, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError in GDSDataset
2 participants