Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update base image to 23.08 #6920

Closed
wyli opened this issue Aug 31, 2023 · 2 comments · Fixed by #6921
Closed

update base image to 23.08 #6920

wyli opened this issue Aug 31, 2023 · 2 comments · Fixed by #6921

Comments

@wyli
Copy link
Contributor

wyli commented Aug 31, 2023

Is your feature request related to a problem? Please describe.
would be great to use the latest base image
https://catalog.ngc.nvidia.com/orgs/nvidia/containers/pytorch/tags

cc @Nic-Ma
@wyli wyli mentioned this issue Aug 31, 2023
Merged
7 tasks
@wyli
Copy link
Contributor Author

wyli commented Aug 31, 2023 

[2023-08-31T22:02:43.905Z] ======================================================================
[2023-08-31T22:02:43.905Z] ERROR: test_correct_results_1 (tests.test_deepgrow_transforms.TestRestoreLabeld)
[2023-08-31T22:02:43.905Z] ----------------------------------------------------------------------
[2023-08-31T22:02:43.905Z] Traceback (most recent call last):
[2023-08-31T22:02:43.905Z]   File "/usr/local/lib/python3.10/dist-packages/parameterized/parameterized.py", line 620, in standalone_func
[2023-08-31T22:02:43.905Z]     return func(*(a + p.args), **p.kwargs, **kw)
[2023-08-31T22:02:43.905Z]   File "/home/jenkins/agent/workspace/Monai-latest-image/tests/test_deepgrow_transforms.py", line 440, in test_correct_results
[2023-08-31T22:02:43.905Z]     result = RestoreLabeld(**arguments)(input_data)
[2023-08-31T22:02:43.905Z]   File "/home/jenkins/agent/workspace/Monai-latest-image/monai/apps/deepgrow/transforms.py", line 874, in __call__
[2023-08-31T22:02:43.905Z]     result = resizer(result, mode=mode, align_corners=align_corners)  # type: ignore
[2023-08-31T22:02:43.905Z]   File "/home/jenkins/agent/workspace/Monai-latest-image/monai/transforms/spatial/array.py", line 838, in __call__
[2023-08-31T22:02:43.905Z]     return resize(  # type: ignore
[2023-08-31T22:02:43.905Z]   File "/home/jenkins/agent/workspace/Monai-latest-image/monai/transforms/spatial/functional.py", line 335, in resize
[2023-08-31T22:02:43.905Z]     resized = torch.nn.functional.interpolate(
[2023-08-31T22:02:43.905Z]   File "/usr/local/lib/python3.10/dist-packages/torch/nn/functional.py", line 3934, in interpolate
[2023-08-31T22:02:43.905Z]     raise TypeError(
[2023-08-31T22:02:43.905Z] TypeError: expected size to be one of int or Tuple[int] or Tuple[int, int] or Tuple[int, int, int], but got size with types [<class 'numpy.int64'>, <class 'numpy.int64'>, <class 'numpy.int64'>]
[2023-08-31T22:02:43.905Z] 
[2023-08-31T22:02:43.905Z] ----------------------------------------------------------------------

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Sep 1, 2023

23.08 would be necessary for other projects.

Thanks.

@wyli wyli closed this as completed in #6921 Sep 2, 2023
wyli added a commit that referenced this issue Sep 2, 2023
@wyli
6920 update base image 23.08 (#6921)
3b27bb6 
Fixes #6920


### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [x] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [x] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Wenqi Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

6920 update base image 23.08 wyli/MONAI
2 participants
@wyli @Nic-Ma