You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The per_label_dict functions in the classes in mixed_measures_processes.py could perhaps be implemented in a base class, which would lead to less lines of code.
The text was updated successfully, but these errors were encountered:
@brudfors - util function is a good idea - will modify to that purpose
Regarding the x_at_y - good point but direction of monotonicity need to be acknowledged
Can't use the histogram due to need to create bins to have equal number of samples
https://github.com/csudre/MetricsReloaded/blob/mikael-mods/utils.py
and imported when needed, i.e.,
https://github.com/csudre/MetricsReloaded/blob/f7f6296468b6556c882cccebb8b6a973d2352e01/pairwise_measures.py#L6
This could also helps in highligting dependencies that would have to be dealt with for a potential MONAI conversion (e.g., skeletonize).
https://github.com/csudre/MetricsReloaded/blob/f7f6296468b6556c882cccebb8b6a973d2352e01/pairwise_measures.py#L428
ref
andpred
are binarised, fix:https://github.com/csudre/MetricsReloaded/blob/f7f6296468b6556c882cccebb8b6a973d2352e01/pairwise_measures.py#L180
https://github.com/csudre/MetricsReloaded/blob/f7f6296468b6556c882cccebb8b6a973d2352e01/pairwise_measures.py#L181
https://github.com/csudre/MetricsReloaded/blob/f7f6296468b6556c882cccebb8b6a973d2352e01/utils.py#L104
utils.py
):https://github.com/csudre/MetricsReloaded/blob/f7f6296468b6556c882cccebb8b6a973d2352e01/utils.py#L93
np.percentile
interpolates, c.f., Fig 7 in Common... paper that points to a discrete value.https://github.com/csudre/MetricsReloaded/blob/f7f6296468b6556c882cccebb8b6a973d2352e01/prob_pairwise_measures.py#L80
x_at_y
for less repeated code:https://github.com/csudre/MetricsReloaded/blob/f7f6296468b6556c882cccebb8b6a973d2352e01/utils.py#L107
i.e.,
https://github.com/csudre/MetricsReloaded/blob/f7f6296468b6556c882cccebb8b6a973d2352e01/prob_pairwise_measures.py#L236
https://github.com/csudre/MetricsReloaded/blob/f7f6296468b6556c882cccebb8b6a973d2352e01/mixed_measures_processes.py#L142
per_label_dict
functions in the classes inmixed_measures_processes.py
could perhaps be implemented in a base class, which would lead to less lines of code.The text was updated successfully, but these errors were encountered: