Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor MAISI bundle to monai 1.4 #634

Merged
merged 22 commits into from
Sep 4, 2024
Merged

Refactor MAISI bundle to monai 1.4 #634

merged 22 commits into from
Sep 4, 2024

Conversation

Can-Zhao
Copy link
Collaborator

Fixes # .

Description

refactor to monai1.4,
add quality check,
correct typo
add download script

Status

Ready/Work in progress/Hold

Please ensure all the checkboxes:

  • Codeformat tests passed locally by running ./runtests.sh --codeformat.
  • In-line docstrings updated.
  • Update version and changelog in metadata.json if changing an existing bundle.
  • Please ensure the naming rules in config files meet our requirements (please refer to: CONTRIBUTING.md).
  • Ensure versions of packages such as monai, pytorch and numpy are correct in metadata.json.
  • Descriptions should be consistent with the content, such as eval_metrics of the provided weights and TorchScript modules.
  • Files larger than 25MB are excluded and replaced by providing download links in large_file.yml.
  • Avoid using path that contains personal information within config files (such as use /home/your_name/ for "bundle_root").

@Can-Zhao Can-Zhao marked this pull request as ready for review August 29, 2024 18:10
@Can-Zhao
update meta
eaa974f 
Signed-off-by: Can-Zhao <[email protected]>
@Can-Zhao
isort, balck
8c14e4f 
Signed-off-by: Can-Zhao <[email protected]>
@Can-Zhao
update meta
bf36c98 
Signed-off-by: Can-Zhao <[email protected]>
@Can-Zhao
update meta
68630ee 
Signed-off-by: Can-Zhao <[email protected]>
@Can-Zhao
rm custom network
ca5bf22 
Signed-off-by: Can-Zhao <[email protected]>
@Can-Zhao
refomat
fd10f8c 
Signed-off-by: Can-Zhao <[email protected]>
@yiheng-wang-nv
auto update
ead2754 
Signed-off-by: Yiheng Wang <[email protected]>
@yiheng-wang-nv
fix type errors
f6b2847 
Signed-off-by: Yiheng Wang <[email protected]>
@yiheng-wang-nv
remove extra f
21c0e3b 
Signed-off-by: Yiheng Wang <[email protected]>
@yiheng-wang-nv
revert other bundle changes
61685a1 
Signed-off-by: Yiheng Wang <[email protected]>
@yiheng-wang-nv
revert large file dataset change
5c42dda 
Signed-off-by: Yiheng Wang <[email protected]>
@yiheng-wang-nv
Copy link
Collaborator

/build

@yiheng-wang-nv
revert vista2d changes
c4fff21 
Signed-off-by: Yiheng Wang <[email protected]>
@yiheng-wang-nv
Copy link
Collaborator

/build

@yiheng-wang-nv
add arg
f68e12a 
Signed-off-by: Yiheng Wang <[email protected]>
@yiheng-wang-nv
Copy link
Collaborator

/build

@yiheng-wang-nv
update error message
3a34a59 
Signed-off-by: Yiheng Wang <[email protected]>
@yiheng-wang-nv
Copy link
Collaborator

/build

@yiheng-wang-nv
Copy link
Collaborator

/build

@yiheng-wang-nv yiheng-wang-nv enabled auto-merge (squash) September 4, 2024 03:28
@yiheng-wang-nv yiheng-wang-nv merged commit 2c5d564 into Project-MONAI:dev Sep 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KumoLiu KumoLiu KumoLiu left review comments

@yiheng-wang-nv yiheng-wang-nv yiheng-wang-nv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Can-Zhao @yiheng-wang-nv @KumoLiu