Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same label dict file for vista3d bundle and tutorial #664

Open
yiheng-wang-nv opened this issue Sep 20, 2024 · 4 comments
Open

Use same label dict file for vista3d bundle and tutorial #664

yiheng-wang-nv opened this issue Sep 20, 2024 · 4 comments
Assignees

Comments

@yiheng-wang-nv
Copy link
Collaborator

To avoid maintaining multiple files

tutorial: https://github.com/Project-MONAI/tutorials/blob/main/3d_segmentation/vista3d/vista3d_spleen_finetune.ipynb

@yiheng-wang-nv
Copy link
Collaborator Author

maisi:

    "dummy6": 129,
    "dummy7": 130,
    "dummy8": 131,

vista3d in model zoo:

    "kidney mass": 129,
    "liver tumor": 130,
    "vertebrae L6": 131,

vista3d tutorial:

    "kidney mass (deprecated)": 129,
    "liver tumor (deprecated)": 130,
    "vertebrae L6 (deprecated)": 131,

Hi @Can-Zhao @heyufan1995 , could you help to confirm if we can use a single version to cover all maisi and vista3d tutorials and bundles? Which version should we use?

@mingxin-zheng
Copy link
Contributor

As we internally discussed before, it would be nice if we can have individual label JSON for each model. But the file should be visible publicly in MONAI tutorial repo and we should use commit hash in the link to ensure the right version to be called.

@yiheng-wang-nv
Copy link
Collaborator Author

vista3d is updated in #657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants