Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate that exporting a saved item collection can lead to an assertion failed #674

Open
ClaudiaMia opened this issue Apr 13, 2024 · 1 comment
Open

Investigate that exporting a saved item collection can lead to an assertion failed #674

ClaudiaMia opened this issue Apr 13, 2024 · 1 comment
Labels
Component: Client Changes to client side of things Type: Bug Something isn't working

Comments

@ClaudiaMia
Copy link
Contributor

ClaudiaMia commented Apr 13, 2024 •
edited by Jomshir98
Loading 

Error: Assertion failed
    at Assert (webpack://pandora-client-web/../pandora-common/src/utility.ts:68:8)
    at webpack://pandora-client-web/./src/components/exportImport/exportImportUtils.ts:22:2
    at webpack://pandora-client-web/./src/components/exportImport/exportDialog.tsx:44:55
@ClaudiaMia ClaudiaMia added the Type: Bug Something isn't working label Apr 13, 2024
@Jomshir98
Copy link
Member

Note: That specific assertion might not be needed if we trust that the code overall works. The problematic thing might be loss of keys set to undefined, causing the isEqual to fail. Simply removing that assertion might suffice.

@Jomshir98 Jomshir98 added the Component: Client Changes to client side of things label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Client Changes to client side of things Type: Bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jomshir98 @ClaudiaMia