Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Verify should grant 'contributor' role for beta-access members who made any merged contribution #725

Open
Sekkmer opened this issue Apr 21, 2024 · 0 comments
Labels
Component: Directory server Changes to the Directory server Priority: Low Type: Improvement Improvement of existing feature

Comments

@Sekkmer
Copy link
Member

Sekkmer commented Apr 21, 2024

currently members who are not part of developers or lead-developers do not get any role assigned to them:

			case 'member':
				if (teams.includes('lead-developers'))
					this._updateGitHubRole('lead-developer');
				else if (teams.includes('developers'))
					this._updateGitHubRole('developer');

				break;

if members without these roles made any contribution that is merged to master branch we could assign collaborator role just as we do for outside contributors

@Sekkmer Sekkmer added Type: Improvement Improvement of existing feature Component: Directory server Changes to the Directory server Priority: Low labels Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Directory server Changes to the Directory server Priority: Low Type: Improvement Improvement of existing feature
Development

No branches or pull requests

1 participant