Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client:commands: Support for async commands #809

Open
Jomshir98 opened this issue Aug 1, 2024 · 0 comments
Open

Client:commands: Support for async commands #809

Jomshir98 opened this issue Aug 1, 2024 · 0 comments
Labels
Complexity: 3 - High Tasks that require significant (architectural) changes. A Lead Developer should participate. Component: Client Changes to client side of things Type: Improvement Improvement of existing feature

Comments

@Jomshir98
Copy link
Member

Currently the commands framework only allows for synchronous handlers. It might be beneficial to expand this support to asynchronous code. Example usage might be waiting with commands completion until appearance action it triggers succeeded before reporting the result.

Parts of commands framework that should support async operations:

  • Final command handler
  • Argument parser
  • [optional] Argument autocompletion (e.g. to allow getting values for autocomplete from the server on-demand)

The chat input should be frozen while the command/autocomplete is running with visual indication that there is progress if it takes longer than half a second. There should also be rather short timeout on the command (e.g. 10 seconds).

@Jomshir98 Jomshir98 added Type: Improvement Improvement of existing feature Component: Client Changes to client side of things Complexity: 3 - High Tasks that require significant (architectural) changes. A Lead Developer should participate. labels Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: 3 - High Tasks that require significant (architectural) changes. A Lead Developer should participate. Component: Client Changes to client side of things Type: Improvement Improvement of existing feature
Development

No branches or pull requests

1 participant