Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move import maps shim to polyfills plugin #1114

Open
2 of 5 tasks
thescientist13 opened this issue May 19, 2023 · 0 comments
Open
2 of 5 tasks

move import maps shim to polyfills plugin #1114

thescientist13 opened this issue May 19, 2023 · 0 comments
Assignees
Labels
CLI documentation Greenwood specific docs enhancement Improve something existing (e.g. no docs, new APIs, etc)
Milestone

Comments

@thescientist13
Copy link
Member

thescientist13 commented May 19, 2023

Summary

Coming out of #1268 / #1269 and related to #1114, instead of deprecating import maps support and now that Safari 16.4 supports them, we should just move it to the polyfills plugin instead.

With both Chrome and Firefox now natively supporting import maps, there is less of a need to autoload es-module-shims when running greenwood develop.

Screenshot 2024-09-04 at 9 21 42 AM

Details

So we would want to do the following from the polyfills plugin instead:

  1. Move the shim JavaScript from being added to the page
  2. Move the logic for adding / remove the shim attributes from <script> tags
  3. Move the dependency from package.json
  4. Update the How It Works section of the docs to call out support level? - new website will be in effect, so not applicable
  5. Could we get by supporting this if it doesn't cover Safari 15.x? Perhaps we could put it into our polyfills plugin? - Indeed :D

Related, we could probably drop the Polyfill plugin in greenwood.config.js for the website too, but could make that another PR.

@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) documentation Greenwood specific docs CLI labels May 19, 2023
@thescientist13 thescientist13 added this to the 1.0 milestone May 19, 2023
@thescientist13 thescientist13 self-assigned this May 19, 2023
@thescientist13 thescientist13 mentioned this issue Mar 9, 2024
38 tasks
@thescientist13 thescientist13 changed the title deprecate import maps shim for development move import maps shim to polyfills plugin Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI documentation Greenwood specific docs enhancement Improve something existing (e.g. no docs, new APIs, etc)
Projects
Status: 🏗 In progress
Development

Successfully merging a pull request may close this issue.

1 participant