Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extirpate (or update) fetch calls in Modeling #14

Open
nicholasjhorton opened this issue May 26, 2015 · 3 comments
Open

extirpate (or update) fetch calls in Modeling #14

nicholasjhorton opened this issue May 26, 2015 · 3 comments
Assignees

Comments

@nicholasjhorton
Copy link

No description provided.

@rpruim
Copy link

rpruim commented May 26, 2015

All that needs doing is an additional require(fetch). Just make sure that it comes after mosaic.

Hmm.. We could have the fetch functions in mosaic check whether fetch is available and use it rather than print the error message. That would avoid the issue of loading packages in the wrong order and hide the error message from people with both packages loaded.

@nicholasjhorton
Copy link
Author

I'd prefer to make it go away. Having people have to install multiple packages or refer to external things that we don't think are germane violates "Less Volume, More Creativity" in terms of complexity.

Just my $0.02,

Nick

On May 26, 2015, at 6:43 PM, Randall Pruim [email protected] wrote:

All that needs doing is an additional require(fetch). Just make sure that it comes after mosaic.

Hmm.. We could have the fetch functions in mosaic check whether fetch is available and use it rather than print the error message. That would avoid the issue of loading packages in the wrong order and hide the error message from people with both packages loaded.


Reply to this email directly or view it on GitHub.

Nicholas Horton
Professor of Statistics
Department of Mathematics and Statistics, Amherst College
Box 2239, 31 Quadrangle Dr
Amherst, MA 01002-5000
https://www.amherst.edu/people/facstaff/nhorton

@rpruim
Copy link

rpruim commented May 27, 2015

There is no need for the fetchData() function to "go away". People who want it can get it using fetch. That maintains a form of backward compatibility.

But I think we should not use it in our stuff. Not sure which sense of "go away" you intended.

I think the biggest issue will be some of Danny's things where IIRC he has used it much more heavily than I have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants