Unable to create English Auction

[mohanv-inmar]

Hey,

I'm trying to create English Auction programatically, as shown in the docs here

I'm adding waitForHighestBid: true when passing the object to createSellOrder as shown in the docs.
but I'm unable to do so, as I'm using openseajs sdk with typescript and when I check the types for the createSellOrder function it doesn't have waitForHighestBid field. (attaching the image for reference)

I'm doing ts-ignore to set the field anyway, still the API is not working as expected. It is creating a normal listing instead of creating a english auction.

[ryanio]

Thanks for pointing out, seems like we were missing the feature completely, have opened a PR to fix (you'll use englishAuction: true in createSellOrder) #1160

[mohanv-inmar]

thanks @ryanio

[mohanv-inmar]

I'm using mumbai chain in opensea.
As the SDK says, only WETH is currently supported for chains other than Mainnet Ethereum

I'm trying to use polygon mumbai WETH token address 0xa6fa4fb5f76172d178d61b04b0ecd319c5d1c0aa as paymentTokenAddress while doing createSellOrder. You can check the token details on polygonscan here

    const paymentTokenAddress = '0xa6fa4fb5f76172d178d61b04b0ecd319c5d1c0aa';

    return this.openseaSdk.createSellOrder({
      asset: {
        tokenId: tokenId,
        tokenAddress: tokenAddress,
      },
      accountAddress: offerer,
      startAmount: baseAmount,
      listingTime: parseInt(startTime),
      expirationTime: parseInt(expirationTime),
      paymentTokenAddress,
      englishAuction: true,
    });

Even when I'm using WETH token address, It's throwing:
Error: No ERC-20 token found for 0xa6fa4fb5f76172d178d61b04b0ecd319c5d1c0aa, only WETH is currently supported for chains other than Mainnet Ethereum

The error is being thrown here in sdk.ts:

opensea-js/src/sdk.ts

Lines 1042 to 1057 in 8150be6

	try {
	if (
	tokenAddress.toLowerCase() == getWETHAddress(this.chain).toLowerCase()
	) {
	paymentToken = {
	name: "Wrapped Ether",
	symbol: "WETH",
	decimals: 18,
	address: tokenAddress,
	};
	}
	} catch (error) {
	throw new Error(
	`No ERC-20 token found for ${tokenAddress}, only WETH is currently supported for chains other than Mainnet Ethereum`,
	);
	}

looks like the function getWETHAddress is throwing error as the WETH for mumbai chain is not added there.

opensea-js/src/utils/utils.ts

Lines 324 to 357 in 8150be6

	export const getWETHAddress = (chain: Chain) => {
	switch (chain) {
	case Chain.Mainnet:
	return "0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2";
	case Chain.Polygon:
	return "0x7ceB23fD6bC0adD59E62ac25578270cFf1b9f619";
	case Chain.Goerli:
	return "0xb4fbf271143f4fbf7b91a5ded31805e42b2208d6";
	case Chain.Sepolia:
	return "0xfFf9976782d46CC05630D1f6eBAb18b2324d6B14";
	case Chain.Klaytn:
	return "0xfd844c2fca5e595004b17615f891620d1cb9bbb2";
	case Chain.Baobab:
	return "0x9330dd6713c8328a8d82b14e3f60a0f0b4cc7bfb";
	case Chain.Avalanche:
	return "0xB31f66AA3C1e785363F0875A1B74E27b85FD66c7";
	case Chain.Fuji:
	return "0xd00ae08403B9bbb9124bB305C09058E32C39A48c";
	case Chain.BNB:
	return "0xbb4CdB9CBd36B01bD1cBaEBF2De08d9173bc095c";
	case Chain.BNBTestnet:
	return "0xae13d989dac2f0debff460ac112a837c89baa7cd";
	// OP Chains have weth at the same address
	case Chain.Base:
	case Chain.BaseGoerli:
	case Chain.Optimism:
	case Chain.OptimismGoerli:
	case Chain.Zora:
	case Chain.ZoraTestnet:
	return "0x4200000000000000000000000000000000000006";
	default:
	throw new Error(`WETH is not supported on ${chain}`);
	}
	};

Can you please add Mumbai chain WETH address to getWETHAddress function ? Or Is there some other way I can solve this issue ?

[mohanv-inmar]

@ryanio I've also raised a PR for the same, #1162