Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not provide worker setup instructions in deployment to healthy work-pools #15513

Closed
cbrown1234 opened this issue Sep 27, 2024 · 1 comment · Fixed by #15632 · May be fixed by Promptless/prefect-test#14
Closed

Do not provide worker setup instructions in deployment to healthy work-pools #15513

cbrown1234 opened this issue Sep 27, 2024 · 1 comment · Fixed by #15632 · May be fixed by Promptless/prefect-test#14
Assignees
@jeanluciano
Labels
enhancement An improvement of an existing feature

Comments

@cbrown1234
Copy link

cbrown1234 commented Sep 27, 2024 •
edited
Loading

Describe the current behavior

Instructions for setting up a worker are always included when deploying a deployment.

Successfully created/updated all deployments!

                        Deployments
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━┳━━━━━━━━━┓
┃ Name                                 ┃ Status  ┃ Details ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━╇━━━━━━━━━┩
│ example-flow/Local Dev (chris-brown) │ applied │         │
└──────────────────────────────────────┴─────────┴─────────┘

To execute flow runs from this deployment, start a worker in a separate terminal
that pulls work from the 'local-dev-docker-chris-brown' work pool:

        $ prefect worker start --pool 'local-dev-docker-chris-brown'

To schedule a run for this deployment, use the following command:

        $ prefect deployment run 'example-flow/Local Dev (chris-brown)'


You can also run your flow via the Prefect UI: https://<redacted>

Describe the proposed behavior

Do not include the details for the setup of the worker if the deployment was to a healthy work-pool with existing workers running

Successfully created/updated all deployments!

                        Deployments
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━┳━━━━━━━━━┓
┃ Name                                 ┃ Status  ┃ Details ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━╇━━━━━━━━━┩
│ example-flow/Local Dev (chris-brown) │ applied │         │
└──────────────────────────────────────┴─────────┴─────────┘

To schedule a run for this deployment, use the following command:

        $ prefect deployment run 'example-flow/Local Dev (chris-brown)'


You can also run your flow via the Prefect UI: https://<redacted>

Example Use

No response

Additional context

We found that the current behaviour is quite confusing to new users coming to an existing setup with working workers.

I discussed issue with Chris (CTO) at the London PACC and it was his suggestion for the enhancement, so he might have already raised an issue for this, so apologies if this is a duplicate. Would be great to have this for the next release of the self-hosted cloud from the perspective of Genomics England
@cbrown1234 cbrown1234 added the enhancement An improvement of an existing feature label Sep 27, 2024
@cbrown1234 cbrown1234 changed the title Do not provide Do not provide worker setup instructions in deployment to healthy work-pools Sep 27, 2024
@cicdw
Copy link
Member

cicdw commented Sep 27, 2024

Thanks for opening this issue @cbrown1234! Will update here on progress, should be doable for the next release (next week).

@cicdw cicdw self-assigned this Sep 27, 2024
@jeanluciano jeanluciano assigned jeanluciano and unassigned cicdw Oct 4, 2024
@jeanluciano jeanluciano mentioned this issue Oct 9, 2024
Merged
4 tasks
This was referenced Oct 30, 2024
Closed
Closed
@frances720 frances720 mentioned this issue Nov 14, 2024
Open
This was referenced Nov 14, 2024
Closed
Closed
Closed
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeanluciano jeanluciano

Labels
enhancement An improvement of an existing feature
Projects
None yet
Milestone
No milestone
3 participants
@cicdw @cbrown1234 @jeanluciano