Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickMix has no station modes #723

Open
haarp opened this issue Nov 30, 2021 · 3 comments
Open

QuickMix has no station modes #723

haarp opened this issue Nov 30, 2021 · 3 comments
Labels

Comments

@haarp
Copy link

haarp commented Nov 30, 2021

Subject of the issue

Related to #700

When a QuickMix station is active, pianobar will fetch availabe modes, but since there are none, the experience is very confusing. It looks as if it's prompting for a name. Additionally, there seems to be a string mistake, as Delete is visible during the selection

Your environment

pianobar-2020-11-28 on Gentoo Linux

Steps to reproduce

  • Start pianobar into QuickMix
  • Press =
    [?] Delete Manage [m]ode? <- Delete isn't supposed to be here, is it?
  • Press m
(i) Fetching modes... Ok.
[?] Pick a new mode:
  • User is left confused here.

Expected behaviour

If no modes are available, don't prompt. I'm not sure if Pandora even offers modes for QuickMix. Probably not?

Actual behaviour

Confusing UI

Thanks! :)

@PromyLOPh PromyLOPh added the bug label Dec 5, 2021
@PromyLOPh
Copy link
Owner

Hi! I was thinking about merging x (which changes quickmix station assignment) into =. Not sure about that yet, so I guess we’ll take the shortcut. Does this patch fix the issue for you? https://6xq.net/paste/pianobar-quickmix.patch.html

@haarp
Copy link
Author

haarp commented Dec 5, 2021

This patch works well for me. Thanks!

I also approve of merging x. More context-based interactive menus in favor of obscure keys is good (I didn't even know about x until now) :)

@PromyLOPh
Copy link
Owner

I merged the fix and will reopen until I moved x into the context menu.

@PromyLOPh PromyLOPh reopened this Dec 11, 2021
thedmd pushed a commit to thedmd/pianobar-windows that referenced this issue Apr 16, 2022
It does not have any modes anyway.

Fixes PromyLOPh#723.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants