-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack pressure display breaks diving helmet air display #34
Comments
If you mean that the timer is ticking down quicker (a bit uneven) than it normally would, that makes sense, because that's exactly what's happening. The timer is calculated using the remaining air and the amount of air used by the diving helmet every tick, but as soon as you use additional air via the jetpack (for example in hover mode), or any other air consuming tool like the extendo-grip, the timer skips a few seconds. I am not sure how you could "solve" this, because I do not think this is a bug, everything is working exactly as it should. It would also not be possible to include the air used by the jetpack in this calculation, because I would have to predict what the user would do in the future. |
The timer ticks down quicker as intended, but in addition to doing this, it
also oscillates up and down. I'm not sure how to describe it exactly, but
watching the timer carefully should show this.
…On Fri, Oct 21, 2022, 2:28 AM Niklas Widmann ***@***.***> wrote:
If you mean that the timer is ticking down quicker (a bit uneven) than it
normally would, that makes sense, because that's exactly what's happening.
The timer is calculated using the remaining air and the amount of air used
by the diving helmet every tick, but as soon as you use additional air via
the jetpack (for example in hover mode), or any other air consuming tool
like the extendo-grip, the timer skips a few seconds.
I am not sure how you could "solve" this, because I do not think this is a
bug, everything is working exactly as it should. It would also not be
possible to include the air used by the jetpack in this calculation,
because I would have to predict what the user would do in the future.
—
Reply to this email directly, view it on GitHub
<#34 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF7R3OV53KWKEZ5E7XBYN6TWEJO4TANCNFSM6AAAAAARFVR5TM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Do you mean the timer on the bottom right oscillates or the visual indicator for the jetpack on the to left? |
I mean that the timer on the bottom left oscillates perfectly in time with
the blinking of the one on the top left
…On Fri, Oct 21, 2022, 3:01 AM Niklas Widmann ***@***.***> wrote:
Do you mean the timer on the bottom right oscillates or the visual
indicator for the jetpack on the to left?
Because the jetpack indicator is meant to blink while it is consuming air
—
Reply to this email directly, view it on GitHub
<#34 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF7R3OW3NDFLCZ46ATJT4KLWEJSWFANCNFSM6AAAAAARFVR5TM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
That's just a coincidence, the timer on the left simply blinks because that is how I choose to represent that the tank is being drained. The timer on the bottom has a small jump everytime air is being drained, which makes sense, but as far as I could see, it only jumps a few seconds down, not up |
I will double check this, I was pretty sure I saw the minute counter on the
timer jump up and down during the times when the other indicator was doing
it's thing.
…On Sun, Oct 23, 2022, 1:10 AM Niklas Widmann ***@***.***> wrote:
That's just a coincidence, the timer on the left simply blinks because
that is how I choose to represent that the tank is being drained. The timer
on the bottom has a small jump everytime air is being drained, which makes
sense, but as far as I could see, it only jumps a few seconds down, not up
—
Reply to this email directly, view it on GitHub
<#34 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF7R3OUC3Z6VCNFFMOEOD43WETXGLANCNFSM6AAAAAARFVR5TM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I've recorded a video of the bug, it definitely happens. |
Thanks, I am not quite sure why that happens but I will look into it |
I think this might be a bug with Create's code to display the air timer and not just for this mod, but the jetpack usage exaggerates it. |
What happened?
When using the jetpack underwater with the diving helmet, the air tank timer fluctuates along with the visual indicator in the top left corner of the screen.
I believe this is caused by the visual indicator changing the actual remaining capacity of the tank to provide one of its visual effects
Mod Version
1.3.2
Minecraft Version
1.18
Forge Version
40.1.75
Relevant log output
No response
The text was updated successfully, but these errors were encountered: