Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extImageUrl is arbitrary and hard-coded. #63

Open
wyattbenno777 opened this issue Mar 9, 2022 · 1 comment
Open

extImageUrl is arbitrary and hard-coded. #63

wyattbenno777 opened this issue Mar 9, 2022 · 1 comment

Comments

@wyattbenno777
Copy link

wyattbenno777 commented Mar 9, 2022

extImageUrl is arbitrary and hard-coded: DAB should accept a method for EXT tokens to reveal their URIs.

showURL(tokenIdentifier) Text {
  // returns the URL as a text. 
  // EXT does not define what is in the metadata, so it can be anything.
  // The easiest way to get the asset URI is not to hardcode, but to ask the canisters for it.
}

Just like there is a method for canisters to show their logo_url.

const extImageUrl = (canisterId, index, tokenIdentifier) =>

@wyattbenno777
Copy link
Author

Still seems hardcoded

const extImageUrl = (canisterId, index, tokenIdentifier) =>

How active is the dev team here? Would a pull request be better??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant