Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: Rename events to use _ instead of : #151

Open
PuruVJ opened this issue Apr 19, 2024 · 0 comments
Open

breaking: Rename events to use _ instead of : #151

PuruVJ opened this issue Apr 19, 2024 · 0 comments
Milestone

Comments

@PuruVJ
Copy link
Owner

PuruVJ commented Apr 19, 2024

Currently we use neodrag:start, neodrag:end and neodrag events. The colon(:) causes issues with Svelte Language tools, and maybe in other environments as well.

From v3, rename these to neodrag_start, neodrag_end.

Why not camelcase(neodragStart)? Because most people who'll be listening to these events are the svelte folks(onneodrag_start), where events are now lowercase, hence we need _ to keep it readable, or the plain js users, who will have the same issue

@PuruVJ PuruVJ added this to the post-2.0 milestone Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant