Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design recommendation page #365

Closed
wants to merge 25 commits into from
Closed

Design recommendation page #365

wants to merge 25 commits into from

Conversation

kshitija-2001
Copy link
Contributor

@kshitija-2001 kshitija-2001 commented Jun 24, 2021

Issue Number

fixes #60

ISSUE #60

Describe the changes you've made

A mood page is made by adding funny movies, sad, energetic movies.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NA

Additional context (OPTIONAL)

Add any other context or screenshots about the feature request here.

Test plan (OPTIONAL)

A good test plan should give instructions that someone else can easily follow.
How someone can test your code?

Checklist

  • I have added my name in the contributors list at the end of README.md file.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • The title of my pull request is a short description of the requested changes.
  • LGMSOC21

@QAZIMAAZARSHAD
Copy link
Owner

QAZIMAAZARSHAD commented Jun 24, 2021

How the user will access this page?

@kshitija-2001
Copy link
Contributor Author

we need to add it in the nav bar

@QAZIMAAZARSHAD
Copy link
Owner

we need to add it in the nav bar

Obviously, name it 'My recommendations'.

@QAZIMAAZARSHAD
Copy link
Owner

Add it in the navbar of every single page.

@kshitija-2001
Copy link
Contributor Author

Ok i will make the changes

@kshitija-2001
Copy link
Contributor Author

Done updating all the nav bar.

@QAZIMAAZARSHAD
Copy link
Owner

QAZIMAAZARSHAD commented Jun 24, 2021

Check responsiveness in both mobile and desktop views.

Share screenshots or live demo link.

@kshitija-2001
Copy link
Contributor Author

3
4
5
6
7
1
2

@QAZIMAAZARSHAD
Copy link
Owner

QAZIMAAZARSHAD commented Jun 24, 2021

Navbar is disoriented.

Looks like you have used a different font use the one which is used in other pages.

Change the line "movie suggestion by feeling and ....." to "My Recommendations".

And if 'my recommendation' doesn't fit in the nav bar use something else.

Also check flip effect and search bar should be functional as well.

@kshitija-2001
Copy link
Contributor Author

Capture

I named it mood still the navbar is disoriented

@kshitija-2001
Copy link
Contributor Author

and search bar is also working

@QAZIMAAZARSHAD
Copy link
Owner

Capture

I named it mood still the navbar is disoriented

Try fixing it

@QAZIMAAZARSHAD
Copy link
Owner

@kshitija-2001 just remove recommendations from the navbar and add it with other genres in the drop down list.

@saimanoharhm
Copy link

@kshitija-2001 Any update? If you face issue in the code let me know with your problem I am here to help you out.

@QAZIMAAZARSHAD
Copy link
Owner

@kshitija-2001 any updates?

@kshitija-2001
Copy link
Contributor Author

yes working on it!

@QAZIMAAZARSHAD
Copy link
Owner

@kshitija-2001 this PR is open since 21 days.

Website has been updated.
I am closing this PR.

Just add my recommendation page in the genres drop-down list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design recommendation page
3 participants