Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Pkg.develop for dev package #87

Closed

Conversation

AntonReinhard
Copy link
Member

@AntonReinhard AntonReinhard commented Oct 31, 2024

This simply skips the Pkg.develop call for the package that is currently being developed. Trying to load it results in ERROR: LoadError: package QEDbase [10e22c08] has the same name or UUID as the active project, see for example https://gitlab.com/hzdr/qedjl-project/QEDbase-jl/-/pipelines/1518348313 . I'm not 100% sure this is the correct fix for the problem, please correct if I'm wrong @SimeonEhrig .

I made two test runs in base and core with this branch
QEDbase: https://gitlab.com/hzdr/qedjl-project/QEDbase-jl/-/pipelines/1521645744
QEDcore: https://gitlab.com/hzdr/qedjl-project/qedcore.jl/-/pipelines/1521655755

And both seem to work fine.

Edit: Changed it so that it tries to install the dev package and catches the LoadError.

@SimeonEhrig
Copy link
Member

Instead using try catch, I think it is better to compare with Pkg.project.name. I can image, the try catch approach could cause problems, because sometimes you want to uninstall and install QEDbase (actual QEDcore and higher in the dependency hierarchy -> QEDbase is a special case). For example, if you build the documentation, the package which is under development, is a real dependency of the doc environment.

@SimeonEhrig
Copy link
Member

I made two test runs in base and core with this branch
QEDbase: https://gitlab.com/hzdr/qedjl-project/QEDbase-jl/-/pipelines/1521645744
QEDcore: https://gitlab.com/hzdr/qedjl-project/qedcore.jl/-/pipelines/1521655755

Can you please link the PR's. I don't know how you did test.

@AntonReinhard
Copy link
Member Author

I made two test runs in base and core with this branch
QEDbase: https://gitlab.com/hzdr/qedjl-project/QEDbase-jl/-/pipelines/1521645744
QEDcore: https://gitlab.com/hzdr/qedjl-project/qedcore.jl/-/pipelines/1521655755

Can you please link the PR's. I don't know how you did test.

I only had these as temporary commits on existing branches because I didn't want to open new PRs everywhere. I reset them after the CI finished, so you can't see them anymore. They did not change anything other than the links to the QuantumElectrodynamics.jl repositories in the gitlab yaml and the github docs building workflow.

@AntonReinhard
Copy link
Member Author

I'm closing this in favor of #88, which should be the more robust solution.

@AntonReinhard AntonReinhard deleted the fix-install-dev-pkg branch November 5, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants