Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to Bootloader.jl to write CPU and GPU tests in different output yaml files #98

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

SimeonEhrig
Copy link
Member

@SimeonEhrig SimeonEhrig commented Dec 16, 2024

@SimeonEhrig SimeonEhrig marked this pull request as ready for review December 16, 2024 13:19
@SimeonEhrig SimeonEhrig requested a review from szabo137 December 16, 2024 13:19
szabo137
szabo137 previously approved these changes Dec 18, 2024
Copy link
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Looks good to me, I just picked some nits in the docstrings and suggested better naming for two command line arguments.

Feel free to merge after addressing the comments.

.ci/CI/src/Bootloader.jl Outdated Show resolved Hide resolved
.ci/CI/src/Bootloader.jl Outdated Show resolved Hide resolved
.ci/CI/src/Bootloader.jl Outdated Show resolved Hide resolved
.ci/CI/src/Bootloader.jl Outdated Show resolved Hide resolved
.ci/CI/src/Bootloader.jl Outdated Show resolved Hide resolved
.ci/CI/src/Bootloader.jl Outdated Show resolved Hide resolved
.ci/CI/src/Bootloader.jl Outdated Show resolved Hide resolved
.ci/CI/src/Bootloader.jl Outdated Show resolved Hide resolved
.ci/CI/src/Bootloader.jl Outdated Show resolved Hide resolved
.ci/CI/src/Bootloader.jl Outdated Show resolved Hide resolved
…utput yaml files

- add function to disable integration tests
@SimeonEhrig SimeonEhrig force-pushed the ciBootloaderOutputOption branch from 33e3292 to ad659f5 Compare December 18, 2024 10:37
@SimeonEhrig
Copy link
Member Author

@szabo137 If the CI of this PR and this PR passed, everything should be ready for merge.

@SimeonEhrig
Copy link
Member Author

@szabo137 I think you can merge. The CUDA runner of the test PR had a time out and now PIConGPU is spawning a lot of jobs because of the release. The generated pipelines looks also correct. I don't believe that my last commit on this PR changed something the content of the generated jobs, therefore it should be fine.

@szabo137
Copy link
Member

Ok, I trust you and will merge. However, if it breaks, you owe me a beer 😉

@szabo137 szabo137 self-requested a review December 18, 2024 15:47
@szabo137 szabo137 merged commit 6ea915f into QEDjl-project:dev Dec 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants