Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login failure to ecoinvent, also seems to have problems with ReCiPe endpoint indicators (midpoint seems fine) #3

Closed
yalinli2 opened this issue Feb 10, 2024 · 3 comments

Comments

@yalinli2
Copy link
Member

A reminder to look into these issues, probably time to update to work with brightway25

@yalinli2
Copy link
Member Author

After updating the eidl module following https://github.com/haasad/EcoInventDownLoader/tree/master, login part has been fixed, but new bugs appear when extracting the data.

In the future it might be best to go back using eidl instead of embedding it in BW2QSD, and it might be better to migrate the relevant modules to QSDsan.

@yalinli2
Copy link
Member Author

This bug related to impact indicators (qsdsan.ImpactIndicator.load_from_file) has been fixed: QSD-Group/QSDsan@7f0b813

Though the bug was not because of BW2QSD, the incompatibility with the new ecoinvent interface still causes problem, the best solution is probably to still use EcoInventDownloader (though it doesn't have a PyPI package, but it's on GitHub: https://github.com/haasad/EcoInventDownLoader), other functions in BW2QSD can be migrated to QSDsan.

@yalinli2
Copy link
Member Author

Closing this issue since the bug has been fixed, but opened #4 until I figure out a good way to maintain the functionalities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant