-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new documentation for the local mode to run the AI-powered transpiler passes #2273
base: main
Are you sure you want to change the base?
Conversation
One or more of the following people are relevant to this code: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just some editorial suggestions!
Co-authored-by: Rebecca Dimock <[email protected]>
Co-authored-by: Rebecca Dimock <[email protected]>
Co-authored-by: Rebecca Dimock <[email protected]>
Co-authored-by: Rebecca Dimock <[email protected]>
Co-authored-by: Rebecca Dimock <[email protected]>
Co-authored-by: Rebecca Dimock <[email protected]>
Co-authored-by: Rebecca Dimock <[email protected]>
Co-authored-by: Rebecca Dimock <[email protected]>
docs/guides/ai-transpiler-passes.mdx
Outdated
coupling_map=fez_coupling_map, | ||
ai_optimization_level=3, | ||
optimization_level=3, | ||
ai_layout_mode=optimize, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is optimize
supposed to be a string literal or a variable? If the latter, it's not defined. Also, can I set local_mode
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks. Fixed in ee25720
docs/guides/ai-transpiler-passes.mdx
Outdated
ai_su2_transpiled_circuit = ai_transpiler_pass_manager.run(su2_circuit), | ||
``` | ||
|
||
The following options are used: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean these are the options used in the code example, or these options are available? Also should link to API reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the link to the API reference in aa8575f
|
||
The following options are used: | ||
* `coupling_map` - Specifies which coupling map to use for the transpilation. | ||
* `ai_optimization_level` - Specifies the level of optimization (1-3) to use for the AI components of the PassManager. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is ai_optimization_level
also a new option for TranspilerService
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's only available for this passmanager
docs/guides/ai-transpiler-passes.mdx
Outdated
* `optimization_level` - Specifies the optimization to use for the Qiskit heuristic algorithms. | ||
* `ai_layout_mode` - Specifies how the AI routing part of the PassManager handles the layout. | ||
|
||
Refer to the #AI-routing-pass section to review the configuration options for this parameter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What parameter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has a line break that shouldn't be there. Fixed in aa8575f
Co-authored-by: Jessie Yu <[email protected]>
Co-authored-by: Jessie Yu <[email protected]>
Co-authored-by: Jessie Yu <[email protected]>
Co-authored-by: Jessie Yu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments but overall looks good. I'd feel better if @beckykd can review the suggestions I gave though 😅
Co-authored-by: Jessie Yu <[email protected]>
Co-authored-by: Jessie Yu <[email protected]>
Co-authored-by: Jessie Yu <[email protected]>
Co-authored-by: Vishal Bajpe <[email protected]>
Fixes #2257
To be merged by 13 Nov 2024