Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content/accept headers to appropriate http requests #2088

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Dec 17, 2024

Summary

Added {"Content-Type": "application/json"} and {"Accept": "application/json"} to the headers of the appropriate http requests. Also added IBM-API-Version to the header of all API requests.

Details and comments

Fixes #2063
Fixes #2064
Also fixes ws-primitives #220

@kt474 kt474 changed the title Add content-header to appropriate http requests Add content/accept headers to appropriate http requests Dec 17, 2024
@kt474 kt474 requested a review from ptristan3 December 19, 2024 15:51
Copy link
Collaborator

@ptristan3 ptristan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have only a minor concern related to the specific date. "IBM-API-Version": "2024-01-01"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Accept header in HTTP requests Use Content-Type header in HTTP requests
2 participants