Replies: 1 comment
-
I put on-hold this conversation until we solve the problem with JSON and |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
From #1285 @akihikokuroda was doing a good optimization passing standard JSON instead of the string. I wanted to propose a set of optimizations after review his pull request:
arguments
as standard JSON similar toconfig
in that pull requestenv_vars
as standard JSON similar toconfig
in that pull requestThe reason behind these proposals is that we are encrypting this data anyway so what we are storing is the string of the encryption.We could receive in the API the JSON, parse it with the JSONField serializer to verify that is a valid JSON (something that we are not doing right now) and store it after encrypt it.
Apart from this. We are storing
arguments
in two places, inarguments
field andenv_vars
field after being encrypted. I propose two approach:arguments
field fromJob
(easiest one)arguments
fromenv_vars
and store them separatelyBeta Was this translation helpful? Give feedback.
All reactions