Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action for version updates #1073

Merged
merged 7 commits into from
Nov 3, 2023
Merged

Conversation

psschwei
Copy link
Collaborator

@psschwei psschwei commented Nov 2, 2023

Summary

Fixes #1061

Update component versions for next release via Github Action.

Details and comments

Sample of changed files:

$ git status
On branch auto-update-version
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   charts/qs-observability/Chart.yaml
        modified:   charts/quantum-serverless/Chart.lock
        modified:   charts/quantum-serverless/Chart.yaml
        modified:   charts/quantum-serverless/charts/gateway/Chart.yaml
        modified:   charts/quantum-serverless/charts/gateway/values.yaml
        modified:   charts/quantum-serverless/charts/jupyter/Chart.yaml
        modified:   charts/quantum-serverless/charts/repository/Chart.yaml
        modified:   charts/quantum-serverless/values.yaml
        modified:   client/quantum_serverless/VERSION.txt
        modified:   docker-compose.yaml
        modified:   docs/deployment/cloud.rst

no changes added to commit (use "git add" and/or "git commit -a")

(compare to files changes in #1063)

Signed-off-by: Paul S. Schweigert <[email protected]>
Signed-off-by: Paul S. Schweigert <[email protected]>
@psschwei
Copy link
Collaborator Author

psschwei commented Nov 2, 2023

I can also update the script to checkout a branch, make the updates, and commit/push the changes if folks would like that added.

@IceKhan13
Copy link
Member

oh, that would be ideal I we would be able just go to actions, click run workflow and specify version to update to. And it will create PR automatically :feelsgood:

@IceKhan13
Copy link
Member

I was expecting happier face expression from feelsgood than :feelsgood:

@psschwei
Copy link
Collaborator Author

psschwei commented Nov 2, 2023

just go to actions, click run workflow and specify version to update to. And it will create PR automatically

To do that, we need an admin for the Qiskit-Extensions org to create a Github token with the appropriate permissions on the repo... not sure @IceKhan13 if you know who to prod to get such a token...

With just the script, I can make it do everything up to opening the PR, but we'd still have to manually create the PR on github.

Signed-off-by: Paul S. Schweigert <[email protected]>
Signed-off-by: Paul S. Schweigert <[email protected]>
@psschwei
Copy link
Collaborator Author

psschwei commented Nov 2, 2023

Action added. Note it won't work until we get the appropriate access token.

Signed-off-by: Paul S. Schweigert <[email protected]>
@psschwei psschwei changed the title Add script for version updates Add action for version updates Nov 3, 2023
Signed-off-by: Paul S. Schweigert <[email protected]>
@IceKhan13
Copy link
Member

IceKhan13 commented Nov 3, 2023

I think we do not even need

token: ${{ secrets.GITHUB_TOKEN }}

default for this action is GITHUB_TOKEN anyway :)

but important things is that is works :)

@psschwei
Copy link
Collaborator Author

psschwei commented Nov 3, 2023

That could be (I had to add a token to test it locally, but that's probably more a quirk of running locally than anything else... will take it out)

Signed-off-by: Paul S. Schweigert <[email protected]>
@IceKhan13
Copy link
Member

should we give it a go?

@IceKhan13 IceKhan13 self-requested a review November 3, 2023 14:27
@psschwei
Copy link
Collaborator Author

psschwei commented Nov 3, 2023

it should be safe to run the action whenever... it'll just cut a PR, but said PR will still need to be reviewed before it merges, so we shouldn't be able to shoot ourselves in the foot...

@psschwei psschwei merged commit 528cea0 into Qiskit:main Nov 3, 2023
6 checks passed
@psschwei psschwei deleted the auto-update-version branch November 3, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ease version updates
2 participants