Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency parsing grammar for gateway allowlist #1459

Merged
merged 17 commits into from
Sep 10, 2024

Conversation

psschwei
Copy link
Collaborator

@psschwei psschwei commented Aug 15, 2024

Summary

Part of #369

This PR adds the dependency specification grammar from PEP
508 (https://peps.python.org/pep-0508/) to use when validating
dependencies via the allowlist.

As a temporary measure, it also simplifies the check to only consider
the dependency and not a specific version. As such, it has dropped the
test for related to dependency version.

Future work should be done to convert the allowlist file from JSON to
the standard requirements.txt format, which would allow for easier
version checking.

Details and comments

@psschwei
Copy link
Collaborator Author

The gateway pod seems to be restarting in the k8s test, not sure why yet

@psschwei
Copy link
Collaborator Author

psschwei commented Aug 15, 2024

huh, it's getting hit with an OOMKilled error...
that doesn't happen locally, could just be an issue in the action...

@psschwei
Copy link
Collaborator Author

ok, bumping the resource limits on the gateway fixed the issue

@Tansito
Copy link
Member

Tansito commented Aug 16, 2024

Good to know because we had the same problem with the scheduler Wed 😂

@Tansito Tansito added the on-hold On hold due to any reason label Aug 16, 2024
@Tansito
Copy link
Member

Tansito commented Aug 16, 2024

Add it on-hold tag until we can work together on this 😄

@psschwei psschwei removed the on-hold On hold due to any reason label Sep 3, 2024
gateway/utils.py Outdated Show resolved Hide resolved
gateway/tests/api/test_v1_serializers.py Show resolved Hide resolved
Signed-off-by: Paul S. Schweigert <[email protected]>

This PR adds the dependency specification grammar from PEP
508 (https://peps.python.org/pep-0508/) to use when validating
dependencies via the allowlist.

As a temporary measure, it also simplifies the check to only consider
the dependency and not a specific version. As such, it has dropped the
test for related to dependency version.

Future work should be done to convert the allowlist file from JSON to
the standard requirements.txt format, which would allow for easier
version checking.
Signed-off-by: Paul S. Schweigert <[email protected]>
Signed-off-by: Paul S. Schweigert <[email protected]>
Signed-off-by: Paul S. Schweigert <[email protected]>
Signed-off-by: Paul S. Schweigert <[email protected]>
Signed-off-by: Paul S. Schweigert <[email protected]>
Signed-off-by: Paul S. Schweigert <[email protected]>
Signed-off-by: Paul S. Schweigert <[email protected]>
Signed-off-by: Paul S. Schweigert <[email protected]>
Signed-off-by: Paul S. Schweigert <[email protected]>
Signed-off-by: Paul S. Schweigert <[email protected]>
Signed-off-by: Paul S. Schweigert <[email protected]>
Signed-off-by: Paul S. Schweigert <[email protected]>
Signed-off-by: Paul S. Schweigert <[email protected]>
Signed-off-by: Paul S. Schweigert <[email protected]>
Signed-off-by: Paul S. Schweigert <[email protected]>
@Tansito Tansito self-requested a review September 10, 2024 23:33
Copy link
Member

@Tansito Tansito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the current status LGTM. Feel free to merge it when the tests pass 🙏

@psschwei psschwei merged commit 792488e into Qiskit:main Sep 10, 2024
10 checks passed
@psschwei psschwei deleted the dependency-parsing branch September 10, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants