Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 593 | Client: deprecate stop in favor of cancel #1494

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Issue 593 | Client: deprecate stop in favor of cancel #1494

merged 1 commit into from
Sep 19, 2024

Conversation

IceKhan13
Copy link
Member

Summary

Deprecate Job.stop in favor of Job.cancel

@IceKhan13 IceKhan13 added the project: client Label to identify features related with client project label Sep 18, 2024
@Tansito
Copy link
Member

Tansito commented Sep 19, 2024

Btw @IceKhan13 we are going to need to update the catalog too, right?

@IceKhan13
Copy link
Member Author

@Tansito , right, once we cut new release we will need to update catalog

@IceKhan13 IceKhan13 merged commit e24c2a2 into main Sep 19, 2024
10 checks passed
@IceKhan13 IceKhan13 deleted the issue-593/depreate-stop branch September 19, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tansito Tansito Tansito approved these changes

@akihikokuroda akihikokuroda akihikokuroda approved these changes

@psschwei psschwei Awaiting requested review from psschwei

Assignees
No one assigned
Labels
project: client Label to identify features related with client project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IceKhan13 @Tansito @akihikokuroda