Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support selecting corpus in web UI #492

Open
pmeier opened this issue Aug 20, 2024 · 0 comments
Open

support selecting corpus in web UI #492

pmeier opened this issue Aug 20, 2024 · 0 comments
Assignees

Comments

@pmeier
Copy link
Member

pmeier commented Aug 20, 2024

With #487 merged, we need a way to select the corpus we want in the web UI. I suggest we just assume we have < 10 corpuses and thus use a dropdown menu. To fill it we need two more things:

  1. An endpoint on the API, i.e. GET /corpuses

  2. A new abstract method on the SourceStorage class, e.g. list_corpuses (name TBD).

    I'm not sure yet if we want to make it a strictly abstract, i.e. decorating with @abstractmethod, because that would require everyone to implement this even if one doesn't want to work with corpuses. Instead we could also leave it undecorated and raise NotImplementedError instead and thus pushing the check to runtime. Thoughts?

In addition, 2. also has to be implemented on builtin source storages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants