Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix value selector widget for IN and NOT_IN operator #506

Open
pmeier opened this issue Sep 9, 2024 · 0 comments
Open

Fix value selector widget for IN and NOT_IN operator #506

pmeier opened this issue Sep 9, 2024 · 0 comments
Assignees

Comments

@pmeier
Copy link
Member

pmeier commented Sep 9, 2024

Reported in #499 (comment)


  1. The vertical spacing should allow for at least three values to be visible at all times.

    image

  2. The value extracted from the widget is wrong. For example if I select the following filter in the modal

    image

    I get the following output in the chat history

    image

    There are two issues here:

    1. It did pick a different document as I did select. In my test I couldn't make out a pattern other than it only ever picked a single one.
    2. The value is still a string rather than a list of strings. This leads to errors in the backend, e.g. Chroma.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants