Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetHoldings Returns List of OrderTicket #8547

Open
3 tasks done
AlexCatarino opened this issue Jan 21, 2025 · 0 comments · May be fixed by #8550
Open
3 tasks done

SetHoldings Returns List of OrderTicket #8547

AlexCatarino opened this issue Jan 21, 2025 · 0 comments · May be fixed by #8550
Labels
consistency feature

Comments

@AlexCatarino
Copy link
Member

Expected Behavior

The SetHoldings method returns a list of OrderTicket as Liquidate does. All methods method that place trade should return OrderTicket (or list of).

Actual Behavior

Returns void.

Motivation

If we need to save the reference to the orders SetHoldings generates, we need to use CalculateOrderQuantity+MarketOrder

Potential Solution

N/A

Checklist

  • I have completely filled out this template
  • I have confirmed that this issue exists on the current master branch
  • I have confirmed that this is not a duplicate issue by searching issues
@AlexCatarino AlexCatarino changed the title SetHoldings Rerurns List of OrderTicket SetHoldings Returns List of OrderTicket Jan 21, 2025
@JosueNina JosueNina linked a pull request Jan 22, 2025 that will close this issue
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
consistency feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor SetHoldings to return a List<OrderTicket> JosueNina/Lean
1 participant
@AlexCatarino