Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation of tolerance parameters #114

Open
kklein opened this issue Mar 12, 2023 · 0 comments
Open

Validation of tolerance parameters #114

kklein opened this issue Mar 12, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@kklein
Copy link
Collaborator

kklein commented Mar 12, 2023

For example, max_relative_deviation or max_absolute_deviation are typically expected to be positive. Yet, we currently do hardly any input validation in the respective Constraint constructors. Validating this input could help users finding sneaky typos/bugs.
@kklein kklein added enhancement New feature or request good first issue Good for newcomers labels Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kklein