Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve memory consumption of AggregateNumericRangeEquality #16

Open
ivergara opened this issue Apr 25, 2022 · 2 comments
Open

Improve memory consumption of AggregateNumericRangeEquality #16

ivergara opened this issue Apr 25, 2022 · 2 comments

Comments

@ivergara
Copy link
Collaborator

AggregateNumericRangeEquality requires ~ 20 GiB of memory (~ 50 M rows).

.fetchall() returns a list. Could we change this to perform the checks in a streaming fashion that doesn't require all of the data in memory at once?

@jonashaag
Copy link
Contributor

Couldn't we "just" do it in SQL?

Otherwise, I agree that it's better to do it in a streaming fashion. Here's a bunch of examples how to do it https://github.com/zzzeek/sqlalchemy/blob/master/examples/performance/large_resultsets.py

@ivergara
Copy link
Collaborator Author

Certainly doing it in SQL would be better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants