Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a preference for memory order (C or F) in tabmat? #392

Open
mlondschien opened this issue Sep 18, 2024 · 1 comment
Open

Is there a preference for memory order (C or F) in tabmat? #392

mlondschien opened this issue Sep 18, 2024 · 1 comment
Labels
question Further information is requested

Comments

@mlondschien
Copy link
Contributor

Followup to Quantco/glum#838. In particular, I'd like to avoid any unnecessary copies when creating a

data_continuous = tabmat.DenseMatrix(data[:, continuous_mask], column_names=column_names)
@stanmart
Copy link
Collaborator

Tabmat has supports both, so no copies will be made when creating the matrices or doing sandwich and matvec operations. I don't know the performance implications, though. C layout feels more natural for columnar data and matvec, but that's just a hunch.

@stanmart stanmart added the question Further information is requested label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants