Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding javadoc to method override param is allowed but flawed #225

Open
supersaiyansubtlety opened this issue Sep 17, 2024 · 1 comment · May be fixed by #227
Open

Adding javadoc to method override param is allowed but flawed #225

supersaiyansubtlety opened this issue Sep 17, 2024 · 1 comment · May be fixed by #227
Labels
bug Something isn't working

Comments

@supersaiyansubtlety
Copy link
Contributor

supersaiyansubtlety commented Sep 17, 2024

Working on a QMap PR based on QuiltMC/quilt-mappings@5f95852

I can edit the javadoc of the param of net.minecraft.world.tick.ChunkTickScheduler#getAllTicks (m_khwqakbu), which is an override of net.minecraft.world.tick.SerializableTickScheduler#getAllTicks.

In the editor it looks like this, with null for the param name:
java_HH9q6JG04r

The mapping file looks like this:

METHOD m_khwqakbu (J)Ljava/util/List;
	ARG 1
		COMMENT used to convert from {@link net.minecraft.world.tick.OrderedTick#triggerTick() OrderedTick.triggerTick}
		COMMENT to {@link net.minecraft.world.tick.Tick#delay() Tick.delay}

And in fakeSource it looks like this:

   /**
    * Mapping not found
    */
   @Override
   public List<Tick<T>> getAllTicks(long time) {

Adding the comment to the base method's param works fine.

@supersaiyansubtlety supersaiyansubtlety added the bug Something isn't working label Sep 17, 2024
@ix0rai
Copy link
Member

ix0rai commented Sep 19, 2024

can confirm. will create a test for this and get it fixed!

@ix0rai ix0rai linked a pull request Sep 19, 2024 that will close this issue
@ix0rai ix0rai linked a pull request Sep 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants